Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update GitHub workflow file for running tests #11173

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Docs: update GitHub workflow file for running tests #11173

merged 2 commits into from
Aug 9, 2024

Conversation

c-ciobanu
Copy link
Contributor

I tried following the guide and added the workflow to my repo but then the action failed with the following error:

error This project's package.json defines "packageManager": "yarn@4.1.0". However the current global version of Yarn is 1.22.22.

Presence of the "packageManager" field indicates that the project is meant to be used with Corepack, a tool included by default with all official Node.js distributions starting from 16.9 and 14.19.
Corepack must currently be enabled by running corepack enable in your terminal. For more information, check out https://yarnpkg.com/corepack.
Error: Process completed with exit code 1.

I enabled Corepack and the workflow run correctly.

Added the extra step in the docs for the people that might incur in the same issue.
Also updated the actions/checkout and actions/setup-node to v4.

@Josh-Walker-GM Josh-Walker-GM added this to the next-release milestone Aug 8, 2024
@Josh-Walker-GM Josh-Walker-GM added release:docs This PR only updates docs changesets-ok Override the changesets check labels Aug 8, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Aug 8, 2024
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I haven't tested this myself but trust your work here. The changes are consistent with what we use on the framework side of things so it all looks good.

I'm glad it worked with just this small change! Hope you're finding redwood good to work with.

Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hold on I see lines 328-335. Do you think we should update the usage there to be consistent with your change above?

@Josh-Walker-GM Josh-Walker-GM added the contributor-pr Use to automatically add PRs to the "Contributor PRs" Project Board label Aug 8, 2024
@c-ciobanu
Copy link
Contributor Author

Oh hold on I see lines 328-335. Do you think we should update the usage there to be consistent with your change above?

Oh yeah, I scrolled through it but totally didn't see it.
Updated there too.

Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Walker-GM Josh-Walker-GM merged commit e614fd5 into redwoodjs:main Aug 9, 2024
41 checks passed
@c-ciobanu c-ciobanu deleted the patch-1 branch August 12, 2024 05:27
@Josh-Walker-GM Josh-Walker-GM modified the milestones: next-release, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check contributor-pr Use to automatically add PRs to the "Contributor PRs" Project Board release:docs This PR only updates docs
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants