fix(auth-providers): Move away from babel for building 'api' packages #11301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:fix
Josh-Walker-GM
changed the title
Josh-Walker-GM
added a commit
that referenced
this pull request
Aug 18, 2024
…es (#11303) This switches from babel to esbuild for building the 'api' auth provider packages. Continuing the work of #11301 but this time for the setup packages. I have not included the dbAuth package deliberately and will follow up with a separate update to that package. I had to make a small change to the `@redwoodjs/cli-helpers` package. This was because tsc was not happy that I was statically importing from a package marked `type: module` from a package marked as `type: commonjs` because it would result in requiring an es module. It was not understanding that the cli-helpers package was dual cjs/esm and that it will be totally fine to either import or require from it. The solution (it appears) is to be specific in the exports field of the package.json. Those edits here made tsc happy to generate types and didn't throw the error. I didn't update the styling of the tsconfig when I changed the cli-helpers package. We should refactor that standalone. I'm really not at all thrilled about my recent changes which use the `moduleResolution: node` because that isn't what we should be using but tsc errors out based on your `module` and `moduleResolution` setting which has been a pain. This for now is okay and we can revisit once we encounter the issue of using two different module resolution algorithms depending on cjs vs esm.
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Aug 19, 2024
…pload-link * 'main' of github.com:redwoodjs/redwood: (52 commits) linting: enable 'typescript-eslint/await-thenable' rule (redwoodjs#11311) refactor(api): Add conditional exports to package.json (redwoodjs#11307) chore(readme): Add my middle initials (redwoodjs#11310) chore(README): Fix formatting. One row (redwoodjs#11309) chore(README): Move Kris from Maintainer to Alumni (redwoodjs#11308) fix(codemods): Move away from babel for building package (redwoodjs#11306) fix(api): Move away from babel for building package (redwoodjs#11305) fix(internal): Move away from babel for building package (redwoodjs#11304) fix(auth-providers): Move away from babel for building 'api' packages (redwoodjs#11301) fix(auth-providers): Move away from babel for building 'setup' packages (redwoodjs#11303) chore(deps): Remove webpack related dependencies (redwoodjs#11299) chore(build): build core with esbuild (redwoodjs#11298) chore(exec test): Clean up (redwoodjs#11302) Detect/resolve ambiguous script names (redwoodjs#9848) chore(lint): tidy up the prettier ignore (redwoodjs#11297) feat(context): Build and publish package as dual esm/cjs (redwoodjs#11294) chore(lint): fix prettier configs and ignores (redwoodjs#11295) chore(docs): update prettier config and format docs content (redwoodjs#11293) chore(check): Refactor 'yarn check' away from being a standalone node script (redwoodjs#11292) chore: delete crowdin config file (redwoodjs#11291) ...
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Aug 19, 2024
…ads-extension * 'main' of github.com:redwoodjs/redwood: (52 commits) linting: enable 'typescript-eslint/await-thenable' rule (redwoodjs#11311) refactor(api): Add conditional exports to package.json (redwoodjs#11307) chore(readme): Add my middle initials (redwoodjs#11310) chore(README): Fix formatting. One row (redwoodjs#11309) chore(README): Move Kris from Maintainer to Alumni (redwoodjs#11308) fix(codemods): Move away from babel for building package (redwoodjs#11306) fix(api): Move away from babel for building package (redwoodjs#11305) fix(internal): Move away from babel for building package (redwoodjs#11304) fix(auth-providers): Move away from babel for building 'api' packages (redwoodjs#11301) fix(auth-providers): Move away from babel for building 'setup' packages (redwoodjs#11303) chore(deps): Remove webpack related dependencies (redwoodjs#11299) chore(build): build core with esbuild (redwoodjs#11298) chore(exec test): Clean up (redwoodjs#11302) Detect/resolve ambiguous script names (redwoodjs#9848) chore(lint): tidy up the prettier ignore (redwoodjs#11297) feat(context): Build and publish package as dual esm/cjs (redwoodjs#11294) chore(lint): fix prettier configs and ignores (redwoodjs#11295) chore(docs): update prettier config and format docs content (redwoodjs#11293) chore(check): Refactor 'yarn check' away from being a standalone node script (redwoodjs#11292) chore: delete crowdin config file (redwoodjs#11291) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from babel to esbuild for building the 'api' auth provider packages.
I added
exportsto the package.json. I added all existing files to the exports field.I updated the tsconfig files to use
Node16module and module resolution. I explicitly set the tsbuildinfo file too. My thinking is that we can be explicit to start with. Once we have all our packages over to esbuild and know the lay of the land then we can deduplicate/refactor our configs.This is a chore but does effect what gets shipped so I'll label it as fix and mark it as next-release.