fix(linting): Re-enable babel presets during linting of javascript projects #11458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 6, 2024
…ojects (#11458) Fixes #11457 In #10867 I removed the presets by default and they are only included in specific cases - for jest, for prerender. It looks like I forgot to consider the case of linting javascript projects. I therefore re-enable these presets in that specific case. It's already on my medium term wish list to simplify and rip out as much of our babel config/reliance as we can. It would be better if this was all just simpler and didn't have as many branches. I also introduced a copy of `isTypeScriptProject` into `@redwoodjs/project-config`. It doesn't add any dependencies to that package and it relies on the functionality already provided in it. I will make a note to refactor our existing usage to use this one. I think that would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11457
In #10867 I removed the presets by default and they are only included in specific cases - for jest, for prerender. It looks like I forgot to consider the case of linting javascript projects. I therefore re-enable these presets in that specific case.
It's already on my medium term wish list to simplify and rip out as much of our babel config/reliance as we can. It would be better if this was all just simpler and didn't have as many branches.
I also introduced a copy of
isTypeScriptProjectinto@redwoodjs/project-config. It doesn't add any dependencies to that package and it relies on the functionality already provided in it. I will make a note to refactor our existing usage to use this one. I think that would be better.