Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix type tests running in ci #11460

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Josh-Walker-GM
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM commented Sep 6, 2024

We expect the root package json to run tests via nx run-many. If we just use tstyche then it won't pick up any custom behaviour that the individual test:types scripts define.

@Josh-Walker-GM Josh-Walker-GM self-assigned this Sep 6, 2024
@Josh-Walker-GM Josh-Walker-GM added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Sep 6, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the chore milestone Sep 6, 2024
@Josh-Walker-GM Josh-Walker-GM merged commit 1cc6d0a into main Sep 6, 2024
50 of 57 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/chore-fix-type-tests-script branch September 6, 2024 20:16
Josh-Walker-GM added a commit that referenced this pull request Sep 6, 2024
We expect the root package json to run tests via nx run-many. If we just
use tstyche then it won't pick up any custom behaviour that the
individual test:types scripts define.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants