fix(cli): explicitly set the version so --version works
#11461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:fix
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 6, 2024
For whatever reason auto merge just rammed #11461 right in even though the server tests failed.
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 6, 2024
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 6, 2024
For whatever reason auto merge just rammed #11461 right in even though the server tests failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason the
--versionflag broke in v8. The code to explicitly set the version for yargs is 2 lines so we may as well be explicit and in doing so we fix the problem.