Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update community discussion link in output from cli - yarn rw upgrade #11468

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jgal1
Copy link
Contributor

@jgal1 jgal1 commented Sep 9, 2024

This is a fix for (#11463) . This PR simply updates the dynamic url generated via the 'yarn rw upgrade' to a static url. The dynamic link yieled no results in a search. The updated url (https://community.redwoodjs.com/c/announcements/releases-and-upgrade-guides/) makes it easy to find the upgrade guide.

This is a quick fix. A better long term solution should link directly to the url for the specific version that was upgraded to, but that likely requires a lot more thinking about generating/standardizing the routes of the community docs themselves.

Test Plan:

Before the fix - run 'yarn rw upgrade' in any project and navigate to the link output by the cli (https://community.redwoodjs.com/search?q=8.0.0%23announcements). Observe a page with no results
Screenshot 2024-09-09 at 4 41 56 AM

After the fix - follow the steps to test the cli and navigate to the cli link where release notes are immediately found.
Screenshot 2024-09-09 at 4 42 24 AM

@jgal1
Copy link
Contributor Author

jgal1 commented Sep 9, 2024

Not sure if I can fix the broken checks myself. It's probab\ly simple but I don't know how to add a label or if I have permission, nor what changesets are, I ran the yarn changesets command I get "No GitHub token found. Please set GITHUB_TOKEN or REDWOOD_GITHUB_TOKEN", I have ssh access to git via the terminal so not sure about that either. Same with the milestone. Please, advise if it is something I can fix by linking to docs or letting me know how. Thanks.

@Josh-Walker-GM Josh-Walker-GM self-assigned this Sep 9, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the next-release-patch milestone Sep 9, 2024
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@Josh-Walker-GM Josh-Walker-GM added release:fix This PR is a fix changesets-ok Override the changesets check labels Sep 9, 2024
@Josh-Walker-GM
Copy link
Collaborator

I didn't have permission to push to the fork to add the changelog entry. It's okay the title is clear enough to completely describe the change. I didn't work on that yarn changesets utility but I know I had to add a github token myself so it can reach out to the github api to fill in some of the details like pr title, number, author etc.

The labels are okay I can deal with those. I think they might have some permission requirements on them.

@Josh-Walker-GM Josh-Walker-GM enabled auto-merge (squash) September 9, 2024 13:51
@Josh-Walker-GM Josh-Walker-GM merged commit 23d4e6d into redwoodjs:main Sep 9, 2024
54 of 60 checks passed
Josh-Walker-GM pushed a commit that referenced this pull request Sep 10, 2024
…grade (#11468)

This is a fix for
[(#11463)](#11463) . This PR
simply updates the dynamic url generated via the 'yarn rw upgrade' to a
static url. The dynamic link yieled no results in a search. The updated
url
(https://community.redwoodjs.com/c/announcements/releases-and-upgrade-guides/)
makes it easy to find the upgrade guide.

This is a quick fix. A better long term solution should link directly to
the url for the specific version that was upgraded to, but that likely
requires a lot more thinking about generating/standardizing the routes
of the community docs themselves.

Test Plan: 

Before the fix - run 'yarn rw upgrade' in any project and navigate to
the link output by the cli
(https://community.redwoodjs.com/search?q=8.0.0%23announcements).
Observe a page with no results
![Screenshot 2024-09-09 at 4 41
56 AM](https://github.com/user-attachments/assets/506ecbbc-bbfd-4df8-bdc7-99ea79e713bf)

After the fix - follow the [steps to test the
cli](https://github.com/redwoodjs/redwood/blob/main/CONTRIBUTING.md#testing-the-cli-in-your-project)
and navigate to the cli link where release notes are immediately found.
![Screenshot 2024-09-09 at 4 42
24 AM](https://github.com/user-attachments/assets/3f0a6ec9-4d86-4ad8-91d0-6ef392143eff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
Archived in project
2 participants