fix(auth0): avoid use of undefined global in browser environment #11531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
approved these changes
Sep 11, 2024
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 11, 2024
) As part of migrating the build tool we likely removed some transpiliation that was allowing `global` in the browser. Switching to `globalThis` is a small change which fixes the issue. I have tested this locally and confirmed the bug before and the fix after. We could also directly use `window` instead but I don't really think there's anything more or less correct about that vs `globalThis`. I didn't really want to go down the road to adding configuration to esbuild to start adding back build time changes to support this.
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 12, 2024
) As part of migrating the build tool we likely removed some transpiliation that was allowing `global` in the browser. Switching to `globalThis` is a small change which fixes the issue. I have tested this locally and confirmed the bug before and the fix after. We could also directly use `window` instead but I don't really think there's anything more or less correct about that vs `globalThis`. I didn't really want to go down the road to adding configuration to esbuild to start adding back build time changes to support this.
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 12, 2024
) As part of migrating the build tool we likely removed some transpiliation that was allowing `global` in the browser. Switching to `globalThis` is a small change which fixes the issue. I have tested this locally and confirmed the bug before and the fix after. We could also directly use `window` instead but I don't really think there's anything more or less correct about that vs `globalThis`. I didn't really want to go down the road to adding configuration to esbuild to start adding back build time changes to support this.
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 12, 2024
) As part of migrating the build tool we likely removed some transpiliation that was allowing `global` in the browser. Switching to `globalThis` is a small change which fixes the issue. I have tested this locally and confirmed the bug before and the fix after. We could also directly use `window` instead but I don't really think there's anything more or less correct about that vs `globalThis`. I didn't really want to go down the road to adding configuration to esbuild to start adding back build time changes to support this.
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 12, 2024
) As part of migrating the build tool we likely removed some transpiliation that was allowing `global` in the browser. Switching to `globalThis` is a small change which fixes the issue. I have tested this locally and confirmed the bug before and the fix after. We could also directly use `window` instead but I don't really think there's anything more or less correct about that vs `globalThis`. I didn't really want to go down the road to adding configuration to esbuild to start adding back build time changes to support this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of migrating the build tool we likely removed some transpiliation that was allowing
globalin the browser. Switching toglobalThisis a small change which fixes the issue.I have tested this locally and confirmed the bug before and the fix after.
We could also directly use
windowinstead but I don't really think there's anything more or less correct about that vsglobalThis. I didn't really want to go down the road to adding configuration to esbuild to start adding back build time changes to support this.