fix(cli): handle both single and double quotes during dbAuth setup #11534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
commented
Sep 11, 2024
Josh-Walker-GM
deleted the
jgmw/fix-handle-double-quotes-in-dbauth-setup
branch
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 11, 2024
…11534) Fixes #11526. We had a few find and replaces which don't work if you elect to have double quotes rather than single quotes. By default we ship with a config that expects single quotes so I am not going to audit the entire cli/framework in this PR to ensure we support double quotes at all times. This addresses the issue and so I think is good enough for now. A lot of these functions are utilities so editing them here should have good coverage in other commands.
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 12, 2024
…11534) Fixes #11526. We had a few find and replaces which don't work if you elect to have double quotes rather than single quotes. By default we ship with a config that expects single quotes so I am not going to audit the entire cli/framework in this PR to ensure we support double quotes at all times. This addresses the issue and so I think is good enough for now. A lot of these functions are utilities so editing them here should have good coverage in other commands.
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 12, 2024
…11534) Fixes #11526. We had a few find and replaces which don't work if you elect to have double quotes rather than single quotes. By default we ship with a config that expects single quotes so I am not going to audit the entire cli/framework in this PR to ensure we support double quotes at all times. This addresses the issue and so I think is good enough for now. A lot of these functions are utilities so editing them here should have good coverage in other commands.
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 12, 2024
…11534) Fixes #11526. We had a few find and replaces which don't work if you elect to have double quotes rather than single quotes. By default we ship with a config that expects single quotes so I am not going to audit the entire cli/framework in this PR to ensure we support double quotes at all times. This addresses the issue and so I think is good enough for now. A lot of these functions are utilities so editing them here should have good coverage in other commands.
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 12, 2024
…11534) Fixes #11526. We had a few find and replaces which don't work if you elect to have double quotes rather than single quotes. By default we ship with a config that expects single quotes so I am not going to audit the entire cli/framework in this PR to ensure we support double quotes at all times. This addresses the issue and so I think is good enough for now. A lot of these functions are utilities so editing them here should have good coverage in other commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11526.
We had a few find and replaces which don't work if you elect to have double quotes rather than single quotes.
By default we ship with a config that expects single quotes so I am not going to audit the entire cli/framework in this PR to ensure we support double quotes at all times. This addresses the issue and so I think is good enough for now. A lot of these functions are utilities so editing them here should have good coverage in other commands.