Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to error message about running yarn rw dev or yarn rw build before the workers can be started #11573

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

cannikin
Copy link
Member

Since job config is loaded from api/dist you need to build the site (either with the dev server, or an explicit yarn rw build) before that directory will exist. This updates the error message you see if api/src/lib/jobs.js can't be found to tell you that info.

@cannikin cannikin added the release:chore This PR is a chore (means nothing for users) label Sep 16, 2024
@cannikin cannikin added this to the chore milestone Sep 16, 2024
@cannikin cannikin self-assigned this Sep 16, 2024
@cannikin cannikin added the changesets-ok Override the changesets check label Sep 16, 2024
Copy link
Collaborator

@pantheredeye pantheredeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I like the simple add on the note: "Already did that? ..."

@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, next-release Sep 16, 2024
@Josh-Walker-GM Josh-Walker-GM merged commit 0d7808b into main Sep 16, 2024
55 of 59 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the rc-jobs-dist-message branch September 16, 2024 22:39
Josh-Walker-GM pushed a commit that referenced this pull request Sep 16, 2024
…ld` before the workers can be started (#11573)

Since job config is loaded from `api/dist` you need to build the site
(either with the dev server, or an explicit `yarn rw build`) before that
directory will exist. This updates the error message you see if
`api/src/lib/jobs.js` can't be found to tell you that info.
@Josh-Walker-GM Josh-Walker-GM modified the milestones: next-release, v8.2.0 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants