breaking(baremetal): Throw an error if there is not enough available space #11638
+18
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes what used to only be a warning (introduced in #11469) and makes it an error.
The idea/plan here is that existing projects have enough time to first configure their baremetal deployments with a free disk space limit they're comfortable with when they upgrade to the v8 minor that includes #11469. And then when this PR is included in the next major release of RW they don't need to make any further changes, only thing different will be that they get an error when their servers eventually (if ever) run low on disk space. Just like it will work for any new projects that deploy to baremetal.
So, kind of like first getting a deprecation warning, and then finally having to make the switch. Only here we go from first only getting a free disk space warning, and then later having the deploy fail (with a clear and helpful error message)