Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rsc): Fix TODO and simplify SSR code #11650

Merged
merged 1 commit into from
Oct 4, 2024
Merged

chore(rsc): Fix TODO and simplify SSR code #11650

merged 1 commit into from
Oct 4, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Oct 4, 2024 •
edited
Loading

Now that the RSC implementation is starting to stabilize I could resolve a TODO and remove a bunch of code that wasn't used/needed

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) experimental This PR relates to only experimental feature(s) labels Oct 4, 2024
@Tobbe Tobbe added this to the chore milestone Oct 4, 2024
@Tobbe Tobbe added the fixture-ok Override the test project fixture check label Oct 4, 2024
@Tobbe Tobbe merged commit 1939f55 into redwoodjs:main Oct 4, 2024
57 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-ssr-fix-create-element-todo branch October 4, 2024 11:40
Josh-Walker-GM pushed a commit that referenced this pull request Oct 8, 2024
@Tobbe @Josh-Walker-GM
chore(rsc): Fix TODO and simplify SSR code (#11650)
476ed3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
experimental This PR relates to only experimental feature(s) fixture-ok Override the test project fixture check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
chore
Development

Successfully merging this pull request may close these issues.
1 participant
@Tobbe