fix(jobs): Fixes creating worker with deleteSuccessfulJobs config setting in JobManager #11653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Job documentation, the JobManager's
deleteSuccessfulJobs
can be used to decide if one wants successfully completed jobs from being deleted from theBackgroundJobs
table.Keeping job run history around is useful for reporting purposes, such s hoe many jobs run over time, how many fails, how many successes, etc.
However, the
deleteSuccessfulJobs
was not being correctly passed to the worker increateWorker
so the worker always used the default value -- true -- and always deleted the job run record regardless of configuration.This PR fixes this issue by setting the config value when creating the worker.