chore: move babel plugins from core package to internal #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
thedavidprice
changed the base branch from
pp-move-babel-plugins-from-core-to-internal
to
main
thedavidprice
changed the title
thedavidprice
commented
Oct 21, 2021
thedavidprice
commented
Oct 21, 2021
| @@ -19,7 +19,7 @@ | |||
| "node-fetch": "2.6.1", | |||
| "tasuku": "1.0.2", | |||
| "toml": "3.0.0", | |||
| "vscode-ripgrep": "1.0.0", | |||
| "vscode-ripgrep": "1.12.1", | |||
There was a problem hiding this comment.
@jtoar FYI: I had a strange yarn install error that I resolved by upgrading. Didn't check the release notes for this yet.
thedavidprice
commented
Oct 21, 2021
| { | ||
| test: ['./api/', './scripts/'], |
There was a problem hiding this comment.
@jtoar FOUND IT! Not sure why this was removed. But this config is necessary for the Jest Babel API config. Added this back in and passing!
…ps://github.com/redwoodjs/redwood into dsp-pp-move-babel-plugins-from-core-to-internal
|
@dac09 this is ready for review |
thedavidprice
changed the title
dac09
reviewed
Oct 22, 2021
dac09
reviewed
Oct 22, 2021
packages/internal/src/build/babelPlugins/babel-plugin-redwood-mock-cell-data.ts
Outdated
Show resolved
Hide resolved
dac09
reviewed
Oct 22, 2021
dac09
approved these changes
Oct 22, 2021
thedavidprice
deleted the
dsp-pp-move-babel-plugins-from-core-to-internal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the Babel plugins from Core to Internal. Core now contains only config.
This replaces #3122 (branched from @peterp branch in that PR)
This branch reverts the
babel-plugin-redwood-mock-cell-data.tsand related files to get both build and tests to pass. Files reverted: