Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated ESBuild as a Web build option #3541

Merged

Conversation

7shantanu7
Copy link
Contributor

closes #3506

@thedavidprice as you mentioned, I didn't touched ESBuild files for the API build process.

@Tobbe
Copy link
Member

Tobbe commented Oct 9, 2021

This looks great @7shantanu7! If you want you can get started on the doc updates needed as well. Let me know if you don't want to do the docs and I'll get someone else to take a look at that 🙂

@7shantanu7
Copy link
Contributor Author

@Tobbe I'll update the doc 👍

@thedavidprice thedavidprice self-requested a review October 14, 2021 00:03
@thedavidprice thedavidprice self-assigned this Oct 14, 2021
@thedavidprice thedavidprice added this to the next-release-priority milestone Oct 14, 2021
Copy link
Contributor

@thedavidprice thedavidprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thedavidprice thedavidprice merged commit d788d79 into redwoodjs:main Oct 16, 2021
@thedavidprice
Copy link
Contributor

Thank you @7shantanu7! Please do let me know if you create a PR to update the docs on https://github.com/redwoodjs/redwoodjs.com Otherwise it's on my list.

@7shantanu7
Copy link
Contributor Author

@thedavidprice redwoodjs/redwoodjs.com#827 👀

@thedavidprice thedavidprice modified the milestones: next-release, v0.38.0 Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ESBuild has been deprecated as a Web build option: needs to be removed from config and docs
3 participants