fix(🧶): update engines property on yarn upgrade
#4940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
packages/codemods/src/codemods/v0.48.x/upgradeYarn/__testfixtures__/default/output/package.json
Outdated
Show resolved
Hide resolved
|
Good catch. We've changed the CRWA template, so this should be adjusted to be the same. |
jtoar
added
action/add-to-ctm-discussion-queue
and removed
action/add-to-ctm-discussion-queue
labels
|
Not directly related to this PR but this had me thinking: We can now remove |
|
@callingmedic911 it's always recommended to run dedupe after install, add, remove, CI, etc. Prior to Yarn 3, we had to use |
…res__/default/output/package.json Co-authored-by: David Price <thedavid@thedavidprice.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running
npx @redwoodjs/codemods@canary upgrade-yarnnoticed @renovate-bot complained when the
enginesproperty inpackage.jsondid not match that of repo.Also noted by @noire-munich in #4822