-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: temporarily disable telemetry on windows #5899
Conversation
✅ Deploy Preview for redwoodjs-docs canceled.
|
Created this issue so we don't lose track. #5901 |
@@ -1,4 +1,5 @@ | |||
import { spawn } from 'child_process' | |||
import os from 'node:os' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be careful these - I'm not sure why... but I've found there are some cases where it throws errors (on Windows... if I remember correctly) - and other places the same imports didn't.
@jtoar - I can't the CI tests to pass ... I wonder if something is actually breaking after this change? |
@dac09 I think CI is just a little flaky sometimes. I just gave it a kick and it's all green now. Here's the latest run: https://github.com/redwoodjs/redwood/actions/runs/2655619534. |
…sson/redwood into dt-fastify-config-plugins * 'dt-fastify-config-plugins' of https://github.com/dthyresson/redwood: fix: temporarily disable telemetry on windows (redwoodjs#5899) fix(deps): update dependency dotenv-webpack to v7.1.1 (redwoodjs#5909) fix(deps): update dependency dotenv-defaults to v5.0.2 (redwoodjs#5908) fix(deps): update dependency webpack-dev-server to v4.9.3 (redwoodjs#5906) fix(deps): update dependency core-js to v3.23.4 (redwoodjs#5905) Fix single-character typo (redwoodjs#5904)
@jtoar as I mentioned in this PR - looks like the fancy node import causes issues.
|
…ctmode-gen * 'main' of github.com:redwoodjs/redwood: (22 commits) Remove "node:os" import from telemetry (redwoodjs#5914) fix: temporarily disable telemetry on windows (redwoodjs#5899) fix(deps): update dependency dotenv-webpack to v7.1.1 (redwoodjs#5909) fix(deps): update dependency dotenv-defaults to v5.0.2 (redwoodjs#5908) fix(deps): update dependency webpack-dev-server to v4.9.3 (redwoodjs#5906) fix(deps): update dependency core-js to v3.23.4 (redwoodjs#5905) Fix single-character typo (redwoodjs#5904) chore(deps): update dependency esbuild to v0.14.49 (redwoodjs#5898) Gitpod hot reload fix (redwoodjs#5888) fix(deps): update dependency @types/aws-lambda to v8.10.101 (redwoodjs#5894) fix(deps): update dependency @testing-library/user-event to v14.2.1 (redwoodjs#5893) fix(deps): update dependency @testing-library/react-hooks to v8.0.1 (redwoodjs#5892) chore(deps): update dependency typescript to v4.7.4 (redwoodjs#5886) feat: add noire-munich to core team (redwoodjs#5891) Fix file structure display (redwoodjs#5889) Make Form generic for better TS support (redwoodjs#5867) chore(deps): update dependency npm-packlist to v5.1.1 (redwoodjs#5885) Bump framer motion version to 6.* as recommended (redwoodjs#5870) chore(deps): update dependency nodemon to v2.0.19 (redwoodjs#5884) chore(deps): update dependency firebase to v9.8.4 (redwoodjs#5879) ...
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
"Closes" #5757, #5728. This isn't a fix, but the behavior is annoying enough that we should've disabled it a long time ago. (So we're disabling it now!)
At first I thought about making these changes in
@redwoodjs/cli
, but doing it in@redwoodjs/telemetry
ended up being simpler.