-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5101: auth.ts: Update eslint-disable-next-line statement to be compatible with js files too #6037
Conversation
…line statement to be compatible with js files too
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3c9ccfc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 14 targets
Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @standup75 👋
This is a simple solution to the problem
You're talking about is this in newly-created JS projects right?
The reason you're seeing a CI failure here is that we lint the template as a part of CI, and the template is in TS. Since the inline-config comment for @typescript-eslint/no-unused-var
rule is gone now, lint errors out. So we need that rule there if we want CI to pass. But I think we can eat our cake and have it too if we just include both rules (see my suggestion).
If we're worried about those differences, another approach could be to transform the js files and remove @typescript-eslint/ as part of the transform. Could be overkill and have side effects
We actually should have a legit step for this as there's a few other transforms we could make. But this is a much larger task.
Ah I missed that this was linked to #6037—understood now! |
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
This is a simple solution to the problem. There might be some difference between eslint's no-unused-var and @typescript-eslint's no-unused-var but it seems like it solves this problem.
If we're worried about those differences, another approach could be to transform the js files and remove
@typescript-eslint/
as part of the transform. Could be overkill and have side effects