-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP test setup #6173
WIP test setup #6173
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4a4863a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 14 targets
Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thank you for this @jasonLaster ! Looks like something promising, I wish I could get your intervention from the next community call. Would you mind adding the proper link to the issue? https://docs.replay.io/docs |
@@ -60,7 +60,7 @@ class CommandBuilder { | |||
} | |||
|
|||
@lazy() get args() { | |||
return this.opts.cmd.parsed._ | |||
return this.opts.cmd.parsed._ as string[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We needed this to be able to build and test but probably isn't required. TS was reporting this as a (string | number)[]
and that was interfering with types elsewhere in this file.
@jtoar - I think the Replay integration started here is very close to ready to merge. We're seeing parity on results between chromium and Replay and little to no overhead. It'd be great to enable workflows for this PR so we can verify everything behaves. Here's a replay of one of the auth tests with some comments I left exploring how it all works. I can't resist digging into a new code base! |
@ryanjduffy the way you used comments in that replay to annotate it as if it was a video (it is I guess! But obviously it seems like so much more than that) is pretty slick. I'll do that in the future. I just enabled workflows it. I noticed that the I rebuilt it starting from main with dependency change in this PR and it looks better! I also kept I'll also keep an eye on checks to make sure all the other ones (build, lint, test) are working so that we can see the smoke test run. |
Ah I'm actually not sure if I can push to this branch because it's from an organization. I can make a copy of this with the commit I wanted to add and you could cherrypick it maybe? |
Tests are passing on the ubuntu runners! 🚀 But failing on windows because it says chromium isn't supported there: https://github.com/redwoodjs/redwood/runs/8243292334?check_suite_focus=true#step:8:60 |
Thanks! I think comments are an underrated feature of Replay since they really unlock the collaborative nature of debugging. Plus, they're a handy second brain so you can pick up where you left off in a debugging session.
I commented this on the new PR as well but wanted to note for anyone else following along that we only officially support playwright 1.19 right now because that's the newest that our Firefox fork supports. That'll improve soon now that the next Firefox ESR (102) has been released to which we'll be updating our fork soon. @jasonLaster - You can close this PR out and we'll work through any remaining issues in the new one. |
* update playwright * downgrade playwright * disable matrix * simplify * remove check * remove @replayio/cypress * fixes * patch args * add upload action * HACK: coerce types * simplify * temporary: suppress repo test * yarn cleanup * add line reporter * Update ci.yml * add test metrics * remove type coercion * revert playwright downgrade and rebuild yarn.lock * Update .github/workflows/ci.yml Co-authored-by: Ryan Duffy <ryan@replay.io> Co-authored-by: Jason Laster <jason.laster.11@gmail.com> Co-authored-by: Ryan Duffy <ryan@replay.io>
Thanks again @ryanjduffy! closing this one as housekeeping since #6361 was merged. |
Messing around to see how easy it would be to record the e2e + smoke tests with Replay.
What is Replay? Good question! Will be hopping on the community call next week, but the short version is that Replay is a time-travel debugger which means you can debug the tests after the fact. Like all good time travelers, when you replay the test, there really is a browser running that really does think that it is running for the first time. This is how you're able to inspect the React Components, add print statements, the whole works.
Here's a loom of me looking at Redwood's router for the first time 😄
https://www.loom.com/share/7cc52fd9988342569078ac446ff6446e