-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added default port ssh port 22 and forwarding of config port setting #6428
Conversation
Might be useful to mention @cannikin here, who helped me on the forum and created the issue. |
Hey @Josh-Walker-GM Congrats on your first open source contribution!! If you could update the docs as well that’d be great. You can find that doc here: https://github.com/redwoodjs/redwood/blob/main/docs/docs/deploy/baremetal.md If you want to test out your changes you can run |
Thanks @cannikin, not a major contribution but happy to help. I've added the required documentation. I notice the only other node-ssh config option which is not handled here is the |
Wellllll I don't think our CLI interface easily handles interactive keyboard...none of our existing CLI commands do it so we've never really tried. We have a couple that use |
Okay I might have a quick look and see if it turns into a big can of worms or not but I agree best to keep the PR as focused as possible. I believe I'll need to update some of the tests. I noticed one failed earlier as it does not like having the additional port option present. |
Sorry for the radio silence! More meetings and travel today, but I’ll be back at home tomorrow and can review. |
Thanks again for the quick turnaround on this one, and congrats on your first open source PR! 🎉 |
My pleasure, was an interesting experience. I hope to perhaps contribute more even if I am a little new to a project like this. |
Related to #6426.
I have added in the default port option to the default server config
DEFAULT_SERVER_CONFIG
and have ensured the configured port setting is passed through to the node-ssh connection.This is my first open-source contribution so thanks for your patience with me.
Release Notes
When doing a Baremetal deploy, you can now specify a port other than 22 to connect to via SSH. In your
deploy.toml
file just add theport
key:[[production.servers]] host = "server.com" + port = 22022 username = "user" agentForward = true sides = ["api","web"] path = "/var/www/app" processNames = ["serve"] repo = "git@github.com:myorg/myapp.git"