Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nx): bust build cache on babel config change #6443

Conversation

virtuoushub
Copy link
Collaborator

@virtuoushub virtuoushub commented Sep 23, 2022

see: https://nx.dev/reference/nx-json#inputs-&-namedinputs


color

nx uses caching to determine which steps to do/not do when running something like yarn build

Out of the box it does it's best to determine which changes correctly trigger a rebuild, however it doesn't really account for config files such as a babel config.

Changes to the babel config file, need to bust the build cache as they can have a huge effect on the built artifacts given we use babel to build our JS. This PR ensures that changes to the babel config, correctly allow for a rebuild of the framework.

@virtuoushub virtuoushub requested review from dac09 and jtoar September 23, 2022 00:19
@jtoar jtoar added topic/ops-&-contributing-dx release:chore This PR is a chore (means nothing for users) labels Sep 27, 2022
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @virtuoushub!

@jtoar jtoar enabled auto-merge (squash) September 27, 2022 07:26
@jtoar jtoar disabled auto-merge September 27, 2022 07:57
@jtoar jtoar merged commit 3e1b840 into redwoodjs:main Sep 27, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Sep 27, 2022
@jtoar jtoar modified the milestones: next-release, v3.1.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users) topic/ops-&-contributing-dx
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants