Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of red squiggles in new lambda functions #7640

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Get rid of red squiggles in new lambda functions #7640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fe3ced
Get rid of red squiggles in new lambda functions
Tobbe Feb 14, 2023
75eb572
Update template syntax
Tobbe Feb 15, 2023
f073772
Merge branch 'main' into tobbe-no-red-lambdas
Tobbe Feb 15, 2023
f3b123a
Merge branch 'main' into tobbe-no-red-lambdas
Tobbe Feb 16, 2023
a85e1ac
Update test snapshots
Tobbe Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions packages/cli/src/commands/generate/function/__tests__/__snapshots__/function.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ exports[`Single word default files creates a single word function file 1`] = `
* @param { Context } context - contains information about the invocation,
* function, and execution environment.
*/
export const handler = async (event, context) => {
logger.info('Invoked foo function')
export const handler = async (event, _context) => {
logger.info(\`\${event.httpMethod} \${event.path}: foo function\`)

return {
statusCode: 200,
Expand Down Expand Up @@ -95,8 +95,8 @@ exports[`creates a .js file if --javascript=true 1`] = `
* @param { Context } context - contains information about the invocation,
* function, and execution environment.
*/
export const handler = async (event, context) => {
logger.info('Invoked javascriptFunction function')
export const handler = async (event, _context) => {
logger.info(\`\${event.httpMethod} \${event.path}: javascriptFunction function\`)

return {
statusCode: 200,
Expand All @@ -113,6 +113,7 @@ export const handler = async (event, context) => {

exports[`creates a .ts file if --typescript=true 1`] = `
"import type { APIGatewayEvent, Context } from 'aws-lambda'

import { logger } from 'src/lib/logger'

/**
Expand All @@ -131,8 +132,8 @@ import { logger } from 'src/lib/logger'
* @param { Context } context - contains information about the invocation,
* function, and execution environment.
*/
export const handler = async (event: APIGatewayEvent, context: Context) => {
logger.info('Invoked typescriptFunction function')
export const handler = async (event: APIGatewayEvent, _context: Context) => {
logger.info(\`\${event.httpMethod} \${event.path}: typescriptFunction function\`)

return {
statusCode: 200,
Expand Down Expand Up @@ -166,8 +167,8 @@ exports[`creates a multi word function file 1`] = `
* @param { Context } context - contains information about the invocation,
* function, and execution environment.
*/
export const handler = async (event, context) => {
logger.info('Invoked sendMail function')
export const handler = async (event, _context) => {
logger.info(\`\${event.httpMethod} \${event.path}: sendMail function\`)

return {
statusCode: 200,
Expand Down
5 changes: 3 additions & 2 deletions packages/cli/src/commands/generate/function/templates/function.ts.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { APIGatewayEvent, Context } from 'aws-lambda'

import { logger } from 'src/lib/logger'

/**
Expand All @@ -17,8 +18,8 @@ import { logger } from 'src/lib/logger'
* @param { Context } context - contains information about the invocation,
* function, and execution environment.
*/
export const handler = async (event: APIGatewayEvent, context: Context) => {
logger.info('Invoked ${name} function')
export const handler = async (event: APIGatewayEvent, _context: Context) => {
logger.info(`<%= '$' %>{event.httpMethod} <%= '$' %>{event.path}: <%= name %> function`)

return {
statusCode: 200,
Expand Down