-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve LogFormatter to include Types and Support Additional Options without the Custom attribute #7813
chore: Improve LogFormatter to include Types and Support Additional Options without the Custom attribute #7813
Conversation
16 replays were recorded for d18e1da. 16 PassedrequireAuth graphql checks
|
@dthyresson nice, can I close #5235 just for housekeeping purposes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a definite improvement over what we currently have, so I think we should merge this! And since it's breaking I'd rather merge it sooner than later so we get it in for v5
There are some more TS tweaks I'd like to see, but let's merge this first, and then I can look at the TS stuff later
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
@Tobbe / @dthyresson Am i correct that after having upgraded to RW 5, this doc section does not apply any longer and needs to be updated? https://docs.redwoodjs.com/docs/logger#with-a-custom-payload What we did in out code base was effectively to remove all |
I see your comment @Philzen. This is so old, I can't really remember the context. I'll try to take a look next week (if I can remember 😅) |
Replaces #5235
Fixes #5228 and rewrites the full logger with proper TS types
Breaking change:
All metadata sent to the logger will now be printed.
Previously if you did
logger.debug({ user }, 'my user')
only "my user" would be printed. Now the full user object will be included in the outputTODO
Docs update to the "custom" log formatter. Should be deprecated as will include additional metadata options now.