Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency typescript to v5 #7845

Merged
merged 8 commits into from
Mar 24, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 17, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) 4.9.5 -> 5.0.2 age adoption passing confidence

Release Notes

Microsoft/TypeScript

v5.0.2: TypeScript 5.0

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the release:chore This PR is a chore (means nothing for users) label Mar 17, 2023
@renovate renovate bot assigned jtoar Mar 17, 2023
@renovate renovate bot force-pushed the renovate/typescript-5.x branch 28 times, most recently from b3e8d6d to 7a06bf2 Compare March 20, 2023 22:53
@renovate renovate bot force-pushed the renovate/typescript-5.x branch 7 times, most recently from 03ac681 to 39c3e0a Compare March 23, 2023 18:17
@renovate renovate bot force-pushed the renovate/typescript-5.x branch from 39c3e0a to b8d4bc3 Compare March 23, 2023 19:06
@renovate renovate bot force-pushed the renovate/typescript-5.x branch from b8d4bc3 to 45c61e2 Compare March 23, 2023 19:49
@thedavidprice
Copy link
Contributor

Breaking changes were very minor (for the framework). See Release Notes here:
https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/

Reminder VS Code can get out of sync between latest TS version for codebase and VS Code TS settings. May need to restart workspace and TypeScript server.

@thedavidprice thedavidprice added the release:breaking This PR is a breaking change label Mar 23, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Mar 23, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@jtoar jtoar added fixture-ok Override the test project fixture check and removed release:chore This PR is a chore (means nothing for users) labels Mar 23, 2023
@replay-io
Copy link

replay-io bot commented Mar 23, 2023

16 replays were recorded for 1db8d9c.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/8a704ac9-d0f1-4a8f-b8ec-e59d43935521>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/aa4175e9-e97e-4630-bea6-1ea3d7b5465e>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/6194e900-4d3e-49b5-8c2b-4532d93308b4>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/a233dde5-610c-46a3-a287-4a36d5947d85>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/372b285d-acdc-49cb-8ba2-bd663c490091>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/7dadbd77-610c-45ff-818e-ad8023ef725b>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/36554f8d-5927-42c6-8d99-45000c10feaa>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/4e4a4351-a211-4810-a9e2-8786376d3256>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/d9361677-79c4-4aa0-a2f8-3190953d18c7>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/c4f7566f-2e2c-457a-a161-7b6d978dee33>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/fe97c6c4-a30c-4782-8a7c-e0374467f528>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/449aa82b-0099-4468-8fda-5fed7641f6ab>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/4cc66671-badc-4d34-9aa5-5912971cd837>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/374b52ba-f2d2-4458-a368-b7d54d34303a>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/d9c3baba-fccc-4301-a8fc-dafa32827bab>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@thedavidprice
Copy link
Contributor

Found an issue with Storybook 6 and TS 5:

Using Alpha for the near-term as we have time leading up to v5 RC. Will watch for stable release.

@thedavidprice
Copy link
Contributor

Merging. Ignoring CodeQL 'cause it's failing everywhere right now for what seems unrelated (artifact upload error).

@thedavidprice thedavidprice merged commit b838eb8 into main Mar 24, 2023
@thedavidprice thedavidprice deleted the renovate/typescript-5.x branch March 24, 2023 01:12
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 24, 2023
@jtoar jtoar modified the milestones: next-release, v5.0.0 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:breaking This PR is a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants