-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk auth): set auth state to loading while reauthenticating #7852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we know if the user is logged in and auth has loaded before we know the exact details of the current user, so we can update the state to reflect this earlier
16 replays were recorded for 221a0ec. 16 PassedrequireAuth graphql checks
|
jtoar
changed the title
fix(clerk auth): split setting
fix(clerk auth): set auth state to loading while reAuthenticating
Mar 28, 2023
AuthProvider
state
jtoar
changed the title
fix(clerk auth): set auth state to loading while reAuthenticating
fix(clerk auth): set auth state to loading while reauthenticating
Mar 28, 2023
Tobbe
reviewed
Mar 31, 2023
jtoar
added a commit
that referenced
this pull request
Apr 1, 2023
) * fix: split setting auth provider state we know if the user is logged in and auth has loaded before we know the exact details of the current user, so we can update the state to reflect this earlier * Revert "fix: split setting auth provider state" This reverts commit 05fbe8f. * fix: start reauthenticate w/ loading to true * feat: avoid clerk specific logic with new prop * add comment
jtoar
added a commit
that referenced
this pull request
Apr 2, 2023
) * fix: split setting auth provider state we know if the user is logged in and auth has loaded before we know the exact details of the current user, so we can update the state to reflect this earlier * Revert "fix: split setting auth provider state" This reverts commit 05fbe8f. * fix: start reauthenticate w/ loading to true * feat: avoid clerk specific logic with new prop * add comment
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Apr 3, 2023
* 'main' of github.com:redwoodjs/redwood: (66 commits) update template README bumps API build target 16.20; fixtures updated (redwoodjs#7995) remove serverless deploy option (redwoodjs#7993) chore(deps): update dependency @clerk/types to v3.33.0 (redwoodjs#7991) feat(clerk auth): make `getToken` options globally configurable (redwoodjs#7947) chore(deps): update dependency firebase to v9.19.1 (redwoodjs#7986) fix(deps): update dependency webpack-dev-server to v4.13.2 (redwoodjs#7989) fix(deps): update dependency @clerk/clerk-sdk-node to v4.8.1 (redwoodjs#7988) fix upgrade.js error message (redwoodjs#7992) fix(clerk auth): set auth state to loading while reauthenticating (redwoodjs#7852) chore(deps): update dependency @supabase/supabase-js to v2.13.1 (redwoodjs#7981) chore(deps): update dependency @clerk/clerk-react to v4.14.1 (redwoodjs#7987) chore: unpublish packages script (redwoodjs#7990) chore(deps): update dependency nx to v15.9.2 (redwoodjs#7983) chore(deps): update dependency @nrwl/nx-cloud to v15.3.5 (redwoodjs#7985) fix(deps): update dependency @apollo/client to v3.7.11 (redwoodjs#7984) chore(deps): update dependency @tsd/typescript to v5.0.3 (redwoodjs#7978) chore(deps): update dependency typescript to v5.0.3 (redwoodjs#7972) chore(deps): update dependency @nrwl/nx-cloud to v15.3.4 (redwoodjs#7977) chore(deps): update dependency nx to v15.9.1 (redwoodjs#7976) ...
jaiakt
pushed a commit
to jaiakt/redwood
that referenced
this pull request
Apr 5, 2023
…dwoodjs#7852) * fix: split setting auth provider state we know if the user is logged in and auth has loaded before we know the exact details of the current user, so we can update the state to reflect this earlier * Revert "fix: split setting auth provider state" This reverts commit 05fbe8f. * fix: start reauthenticate w/ loading to true * feat: avoid clerk specific logic with new prop * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://community.redwoodjs.com/t/clerk-the-signup-and-signin-components-cannot-render-when-a-user-is-already-signed-in-unless-the-application-allows-multiple-sessions-since-a-user-is-signed-in-and-this-application-only-allows-a-single-session/4694/5.
This is to solve another mismatch in auth state between Redwood's auth provider and Clerk. We know if the user is logged in and auth has loaded before we know the exact details of the current user, so we can update the state to reflect this earlier and avoid the router hanging on to old state.