-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share template variables between pages and models in scaffold #7894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 replays were recorded for 14a16de. 16 PassedrequireAuth graphql checks
|
@cannikin I think this is your territory, would you like to take a look please? |
It's been a while, I don't really recognize any of this code, but it looks like it's just reorganizing a bunch of functions/vars into a object that's then destructured at the end? Seems fine to me! |
Yep, nothing new here 👍🏻 |
jtoar
approved these changes
Mar 23, 2023
jtoar
pushed a commit
that referenced
this pull request
Mar 25, 2023
jtoar
pushed a commit
that referenced
this pull request
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a reasonable answer to backwards compat in the templates, couldn't find a good way to test it though (other than all the existing tests not crashing)