Allow multiple spaces in PRISMA_DIRECT_URL_REGEXP

[dennemark]

Allows multiple spaces between directUrl = env, since some code formatters add these to schema.prisma.

[replay-io]

15 replays were recorded for d154a9c.

0 Failed

15 Passed

• useAuth hook, auth redirects checks
• Check that a specific blog post is prerendered
• Check that about is prerendered
• Check that homepage is prerendered
• Check that meta-tags are rendering the correct dynamic data
• Check that you can navigate from home page to specific blog post
• Waterfall prerendering (nested cells)
• RBAC: Admin user should be able to delete contacts
• RBAC: Should not be able to delete contact as non-admin user
• Smoke test with dev server
• Smoke test with rw serve
• Loads Cell mocks when Cell is nested in another story
• Loads Cell Stories
• Loads MDX Stories
• Mocks current user, and updates UI while dev server is running

View test run on Replay ↗︎

[thedavidprice]

@dennemark the regex change looks fine. It just seems strange to me there could be multiple whitespaces. re: "since some code formatters add these to schema.prisma." Can you paste an example and give a bit more background?

@dthyresson Could I loop you in on this one? I'm likely being too cautious on this one. Just didn't want to open things up too wide and someone end up with an edge case bug.

[dennemark]

The official Prisma VSCode extension does this kind of formatting. https://marketplace.visualstudio.com/items?itemName=Prisma.prisma

[dthyresson]

@dennemark Thanks for this improvement. As I understand it, the regex needs to handle the case where you've added a directUrl and Prisma prettify-ing has added spaces to align the content. And thus, formatter with the spaces, the regex won't match.

Makes sense.

Could we add this scenario to the tests so there is a test for:

• no directUrl
• formatted, unaligned
• formatted, aligned with spaces

That way we cover the cases and won't have a regressions.

Thanks!

[dennemark]

• no directUrl
• formatted, unaligned
• formatted, aligned with spaces

I have added the formatted test, the other ones are already existing. They take their schema from fixtures. Those fixtures are actually also formatted, but they got along with one space test, since they did not include the shadowDatabaseUrl. I added a test case where I did not import from fixtures, but provide a multi-line string. Works out.
I did not want to export the Regex, so I think this additional test should be ok?!

[dennemark]

is it possible to merge? :)