-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Conditionally show nudge about upgrade version toml tags #8039
Conversation
16 replays were recorded for 9d6347c. 16 PassedrequireAuth graphql checks
|
Right now, to try the v5 RC you have to do |
It shouldn't be too difficult to list all the available versions, running
The difficulty might come from collectively deciding on a fixed list of rules about what new version(s) to notify about based on the current version. Otherwise I imagine it should be a relatively basic mix of string processing, filtering the versions list and using semver comparisons. |
@Josh-Walker-GM Let's get this one in as-is. I like your ideas re: seeing a list of available versions, but it might be solved even more simply with a prompt + confirmation:
Or something like that... At least we'd give better visibility into possible version issues before running the upgrade. Regardless, this is for a follow-on PR (if at all).
^^ @Tobbe agreed this was super annoying. It's also an edge case we can manage better via process the next time around. Thanks, gents! Getting this one in. |
Problem
The nudge to include versions inside the toml
notifications.versionUpdates
happens for both tags and specific semver versions. It does not make sense for specific versions to be included only tags.Changes
Ping
@Tobbe - as you highlighted