Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error out when using Vite with RW v5 #8040

Merged
merged 20 commits into from
Apr 25, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Apr 12, 2023

With these changes it's possible to use Vite with the upcoming v5 release of Redwood.

The downside is that prerendering doesn't actually prerender the pages marked for prerendering.

Is it worth merging this to unbreak vite in v5 while I/we keep working on a better solution? Or should we just wait until a solution is found that makes prerender work again?

Closes #8036

@replay-io
Copy link

replay-io bot commented Apr 12, 2023

16 replays were recorded for 41f108d.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/fb3d5bde-7bab-4f2a-8904-2b68af373e57>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/c52847e3-83a6-4002-9637-2d62b1bf6daa>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/78b9abde-cada-497a-8176-43ac5fbc9d0e>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/58b0f0b1-308f-4270-b9d5-31c77de22b8a>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/639fa027-d45d-43c6-ac6a-cdd25e598b21>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/f24eb596-62cd-4ab6-b7c5-d4e909934127>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/4c7f9b86-c513-47b2-a439-cf8af0593b41>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/c3780b74-6dda-4d00-a0e9-8207a140fad2>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/5b4f286e-c972-469a-a9bb-fdc80a51e17e>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/d255989e-21c4-471e-9cd8-6b19b1c35869>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/010c3a84-51fa-493e-9578-0c3a6dbba8f2>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/fd2281d6-961b-4f20-9aa0-9be3df8148ac>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/20cfb635-8a9a-4212-80a9-75ed6a2c5b4c>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/433a30f7-6d88-4f93-b61c-8eaa83288a47>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/26127fba-3904-4d3b-bccf-ff15b205a810>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@Tobbe Tobbe added the release:fix This PR is a fix label Apr 12, 2023
@Tobbe Tobbe mentioned this pull request Apr 12, 2023
1 task
@Tobbe Tobbe enabled auto-merge (squash) April 25, 2023 04:37
@Tobbe Tobbe merged commit 1590372 into redwoodjs:main Apr 25, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Apr 25, 2023
@Tobbe Tobbe deleted the tobbe-vite-prerender branch April 25, 2023 06:32
@jtoar jtoar removed this from the next-release milestone Apr 27, 2023
@jtoar jtoar added this to the v5.0.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Vite doesn't work in RW v5 RC
2 participants