Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Install studio package if not found #8058

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Conversation

Josh-Walker-GM
Copy link
Collaborator

Problem
The studio package is not included by default so the CLI command fails to import and start the studio.

Changes

  1. Automatically install the @redwoodjs/studio package if it is not found.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label Apr 18, 2023
@Josh-Walker-GM Josh-Walker-GM self-assigned this Apr 18, 2023
@replay-io
Copy link

replay-io bot commented Apr 18, 2023

16 replays were recorded for 6162030.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/63df219a-b563-4b3f-98c7-2919f2ead525>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/8b2df1f7-6e8b-442d-898b-4b8221036771>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/088f6345-8f23-4766-aa4b-40360fbe7424>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/bfd5d615-bbfd-4754-8151-02b8631c0dc6>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/fbd18e1f-e33c-4ecf-b792-ec34972c489d>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/c877717c-f1f4-4aab-8be8-0256fc707664>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/963e2e2c-f749-4909-9627-3f836bf8216b>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/ef9c5165-dc52-44fe-b58b-f8dc7b882590>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/4cb8c321-16c8-4ecf-ada6-4ec42c10c5af>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/08c23746-7ffd-435c-86fa-01c717768149>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/3cff56c6-91fc-445b-9f78-808da3aeb830>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/eab27217-2551-44f4-94f5-2099419bb3e5>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/52a9486d-424a-4a68-8ee6-7737e32a0deb>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/2c6a23ec-e37d-4fc5-8ca7-7a1379425d02>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/2810cfac-9ca6-4c27-a86a-eae3c94a724d>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@replay-io
Copy link

replay-io bot commented Apr 18, 2023

16 replays were recorded for 7f619f9.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/468c8c69-f1de-41ba-ba0a-bfee9413f5eb>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/71507b39-4c85-4fd8-beac-886da3d27771>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/499c4e2d-33de-4753-9a4e-3216f493b2c6>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/0c9dff08-7257-45a7-91f0-84a018065974>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/6b124f72-476b-42e6-9c5a-51af48878314>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/d2f22387-b16b-45c3-ac63-edbc73fd1755>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/9072ccb5-cc8d-4096-923e-fe1f94e06d52>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/b2f4d8bf-b25b-4d2d-a1c7-ff4d02898f16>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/8541c200-5b05-4d7b-878b-c5f9b7520301>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/41836435-3472-4d1e-af87-1b0c6739a268>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/202737d3-89ca-456a-a0d3-985b66d27b3e>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/34ace0b1-f266-44d7-8556-b9027e0bcef1>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/50caf9e2-bbfb-440c-948e-d0e9dae8b9d6>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/0dac45ac-5082-4841-86d9-368cee0c8cfb>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/36504723-8dd9-4102-9c65-c00314c8a32b>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that we'll iterate on this

@jtoar jtoar merged commit 090ef33 into main Apr 19, 2023
@jtoar jtoar deleted the jgmw-studio-module-install branch April 19, 2023 00:45
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Apr 19, 2023
@jtoar jtoar modified the milestones: next-release, v5.0.0 Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants