Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crwa): Fix failure in case of disabled telemetry #8062

Merged
merged 16 commits into from
Apr 20, 2023
Merged

Conversation

Josh-Walker-GM
Copy link
Collaborator

Problem
Canary create-redwood-app fails when telemetry is disabled because the active spans and other otel properties are undefined in that case.

Changes

  1. Option chain the actions that happen on otel spans.

Ping
@jtoar - These changes must have got lost in my local copy when we were getting #8043 in.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label Apr 20, 2023
@Josh-Walker-GM Josh-Walker-GM requested a review from jtoar April 20, 2023 11:35
@Josh-Walker-GM Josh-Walker-GM self-assigned this Apr 20, 2023
@replay-io
Copy link

replay-io bot commented Apr 20, 2023

16 replays were recorded for 25b23d5.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/185329c2-cd2d-43d8-9f22-9c0428befe34>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/a8b08b96-a69c-46fe-8c73-222c5a34ea66>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/48b55a05-2cb2-481f-a9c8-5be53291fc3d>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/4c434a0c-395d-4727-8b04-254b8acc8b58>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/879af010-0285-48e0-bc61-de2d573b898e>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/89e75ead-9fd6-4a80-a68a-064606309413>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/003b74d6-3114-4670-86a8-728732aaac03>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/6d7598af-0bc8-4b3b-a373-9c44926cb90e>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/ef2665b9-4889-406b-9abc-8e51387cd28a>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/6604fc60-c659-4a73-8cc0-f0662f341ce7>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/3cb921c4-f9ed-42ca-8879-34a7dc8d3b7a>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/6f0c5dfe-2efb-4dc6-ada2-4a015b64c7c8>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/886a4b83-1219-4e5c-afff-f94f5e26ed62>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/34e9ee73-344f-4655-aa3a-317bc67e081a>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/19423ec9-a07a-4544-98d5-a4d7f2babcd5>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@jtoar jtoar merged commit 9fa6bb3 into main Apr 20, 2023
@jtoar jtoar deleted the jgmw-crwa-otel-update branch April 20, 2023 13:27
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Apr 20, 2023
@jtoar jtoar modified the milestones: next-release, v5.0.0 Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants