Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRWA, Tui] Try removing Babel and bundling minimally #8074

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Apr 21, 2023

Broken out of #8071. @Josh-Walker-GM I think this one could be merged for an immediate gain while we think more about the subtler details in 8071. What do you think?

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Apr 21, 2023
@replay-io
Copy link

replay-io bot commented Apr 21, 2023

16 replays were recorded for fe23a0a.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/10c2fca3-1126-48ee-9c77-10e2361887b8>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/bd4664af-ce13-4b0f-89e0-77bca377262e>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/f39f9ccd-7f17-48b7-9b0a-ba477dae77d2>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/90db7a82-db88-44c4-aa0c-e759c81c5f6f>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/90587de7-b0f7-4f59-8f72-fd3c17739c5e>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/e4a203a0-cfa8-4717-aef8-5a17267028b8>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/5841afaf-c256-4a0c-a65e-7b602c019ec1>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/57078df4-11f5-4ff6-a52d-98c78d8f452c>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/621c7e8f-0803-491e-ab4d-30fc1afcaf60>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/ea2c85df-9556-41a6-a2da-9cfe00222250>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/d89780bb-e004-4bbb-9f4f-800ca402e291>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/231e792e-3f09-4770-add6-6eeb341d6229>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/dac04a26-a6c8-4406-8ba9-3fd707052671>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/0f63fa25-70b6-417e-9c05-2795cd800fe8>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/fa6fd7eb-f79a-49e1-82f0-c37119b83b9c>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me like a good move given the small changes needed.

@jtoar jtoar merged commit bfeba74 into main Apr 21, 2023
@jtoar jtoar deleted the ds-crwa/try-rming-babel branch April 21, 2023 17:26
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Apr 21, 2023
@jtoar jtoar modified the milestones: next-release, v5.0.0 Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants