Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency listr2 to v6 #8105

Merged
merged 6 commits into from
Apr 26, 2023
Merged

fix(deps): update dependency listr2 to v6 #8105

merged 6 commits into from
Apr 26, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 25, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
listr2 5.0.8 -> 6.3.1 age adoption passing confidence

Release Notes

listr2/listr2

v6.3.1

Compare Source

Bug Fixes
  • task: splat on titles for brownie and nx repositories (a756a47)

v6.3.0

Compare Source

Bug Fixes
  • renderer/default: update how bottom bar is checked (0b5dab9)
Features

v6.2.0

Compare Source

Bug Fixes
Features
  • force publish since semantic-release is stuck (fa0fae1)

v6.1.0

Compare Source

Bug Fixes
  • add options to processoutput fix eol problem (e6d6474), closes #​670
  • process-output: make everything optional (148cb81)
Features
  • add related documentation to process output and update with feature flag (c1ede63)

v6.0.4

Compare Source

Bug Fixes

v6.0.3

Compare Source

Bug Fixes
  • logger: update logger for empty messages with fields not writing undefined (30c5baf)
  • renderer: update typings (a080d11)
  • update logger pushing undefined for tasks without titles (7bed36c)
  • renderer: update typings (a080d11)

v6.0.2

Compare Source

Bug Fixes
  • typing issues with secondary renderer not being changed (f5c9871)

v6.0.1

Compare Source

Bug Fixes

v6.0.0

Compare Source

Bug Fixes
  • comply with breaking changes on types (23d1855)
  • expose colorrette and some more utils (d9e0812)
  • handle non string values (04c583c)
  • issue with empty skips from before (5c04f19)
  • issue with test coverage (1bd74d9)
  • missing stuff (9d442f8)
  • move wrong dependency type to dev (d93f135)
  • refactor some of the api for work (4bce0c0)
  • task: update naming scheme and hide taskfn (1b19a89)
  • the issue with rendering, make default renderer method naming scheme similar to logger (6c5c172)
  • update ci configuration for codecov and semantic-release pushback (4f94de6)
  • update dependencies and configuration (ee07b2a)
  • update deps (8140f28)
  • update jsdocs, change default renderer option (2d99b67)
  • update logger to be more flexible (3b76139)
  • update option name (9ddfea3)
  • update splat from logger (142be8c)
  • update typescript path and the import paths accordingly (0d3afcb)
Features
  • add new options for base listr (1a41939)
  • add possiblity to force unicode on all systems (08ba157)
  • add process hooks to hook terminal to obstruct anything while rendering (db7398d), closes #​662
  • add splat util.format to output, title and skip (02e5432)
  • add task retry delay (b72eaf3), closes #​668
  • adds new test renderer (6098586)
  • ditch rxjs completely and use event emitter based approach (213bc76)
  • expose and alias more of the interfaces since they can be used outside (38479b0)
  • expose more api for pending tasks (a7b1981)
  • expose path from task directly (5c393d0)
  • expose spinner through its own stateful class (99bd97d)
  • process-output: ability to overwrite streams on process output (474e096)
  • process-output: hide cursor as before when hijacking output (a0e150c)
  • renderer: simplify and add eager option (5248c78)
Performance Improvements
  • bump node version to 16 since 14 dies in less than 1 month (36dde30)
  • change field name (91f6fda)
  • change naming scheme for renderer tasks to make it singular (cbcdfe2)
  • change the default behavior for error collection (4785730)
  • change the exposed API of the application (513ed76)
  • changes and reuses logger component and pluggable plugins for renderers (cbf668c), closes #​651 #​646 #​613
  • constants: changes names of listr states (cf9c19d)
  • default fallback renderer changed to simple renderer (67b5b62)
  • deps: ditch-pmap instead of a basic implementation (eb7cfdc)
  • go full esm on jest/ts-node, use dynamic imports for esm modules on default renderer (9cc01c0)
  • handle prompts properly, rename loglevels to listrloglevels (73cad76)
  • logger: move splat to logger as well and refactor multiline message handling (fea0227)
  • logger: unify the logger field input (30a2658)
  • logger: use logger prototype instead of instance for initiating, always pass default (1fc7ef9)
  • move prompt to own instance (7cacdbd)
  • refactor and simplify default renderer (a9ec3c4)
  • refactor the name to shorten it, since it is still understandable (acfe5bd)
  • rename error field of listr and share through parent tasks (88eb34e)
  • rename field (aa831bd)
  • rename for consistency (0530c22)
  • rename nonttyrenderer and its related settings (f29bb12)
  • rename property (5e8a7be)
  • renderer: change the default (796826a)
  • update api and rename for consistency (ffbe9f2)
  • update documentation, rename presets (4041410)
  • update how bottom bar is handled through process output buffer (1729962)
  • update how logger is implemented and injected (3146082)
  • update how test renderer logs and use a serializer instead of constantly creating objects (5859ac4)
  • update naming scheme (acc1f9d)
BREAKING CHANGES
  • renames default renderer options collapse to collapseSubtasks
  • On the main Listr task list, conditions for fallback and silent renderer have been renamed.
  • rendererSilent has been renamed to silentRendererCondition.
  • rendererFallback has been renamed to fallbackRendererCondition.
  • Default fallback renderer has been changed from verbose to simple, since simple can mostly handle non-tty at this point.
  • Changes default error collection behavior to false from minimal, since this is the most hidden feature of them all, and it should be opt-in.
  • err field in manager has been renamed to errors as well
  • renames retry property withError to basically error
  • renderer: The default behavior of handling longer output has been changed to wrap.
  • nonTTYRenderer, nonTTYRendererOptions in Listr tasks has been renamed to fallbackRenderer and fallbackRendererOptions respectively.

To be honest this was staying for the original Listr compatability but since so much is refactored, it made sense to change it to match where the others are used.

  • Minimum node version usable is increased to node16 since node14 has been put out of the maintenance circle.
  • Moves prompt to another channel and avoids using the output channel for prompts.

Properly uses the ProcessOutputHook for Simpler Renderer. Hooks on prompts.

Moves the ProcessOutputBuffer logic in to its own class, where streams can be recorded.

Deprecated through has been ditched by using a basic WritableStream, idk why i did use it in the first place, I guess it was coming from the original Listr implementation.

Still uses ansi escape parsing to properly render the output, still limited by mostly the log-update but buffering output for bells and clear line or hide cursor charachters breaks stuff too much, so it is the safe way.

  • Renames the err field to errors in Listr class. So error collection is shared instead of injected.
  • This completely breaks old behavior with the renderers, even the basic parameters are changed.

Now the renderers for things like timer and timestamps takes in pluggable components through the shared constants, which makes them user configurable.

The logger interface and logger itself has changed to handle all the common cases for any kind of renderer, eventhough it does not use all of them at the same time.

This is a big change that might make the user checkout the new README.

  • constants: State names has been changed, which might break backwards compatability.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the release:chore This PR is a chore (means nothing for users) label Apr 25, 2023
@renovate renovate bot assigned jtoar Apr 25, 2023
@renovate renovate bot force-pushed the renovate/listr2-6.x branch 2 times, most recently from 1bea251 to 91ef04c Compare April 25, 2023 15:02
@renovate renovate bot force-pushed the renovate/listr2-6.x branch from 91ef04c to 447f0fa Compare April 25, 2023 15:07
@renovate
Copy link
Contributor Author

renovate bot commented Apr 25, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@replay-io
Copy link

replay-io bot commented Apr 25, 2023

16 replays were recorded for ea059f6.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/031dd044-aff5-4f34-8c1e-0c1ac8e73e1e>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/60b67272-62c9-42c3-ad5b-e4b3fa9de78b>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/e72a34d1-f6cc-4511-9bd5-e49df431918e>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/05897716-b1b5-4619-81da-4b0c7378ea5c>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/7bcdffe0-a1ee-4a71-9641-c560c79c9b1d>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/37cca862-e40c-473c-aa50-d514d484fb49>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/43a67fed-2cfe-411f-8be8-3b285a6263c0>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/6c5168b9-6a67-4a2c-9e18-2e3d0fba1aa2>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/2ccf3a18-6301-45d8-af42-b0cc01903204>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/c744ac15-b01b-4a5b-9bcd-8e0a7b64d094>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/c4679e93-95a4-4cc6-b43d-8fa5cec8588b>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/d1905b11-f4e6-4817-b9c9-7a315dde67e5>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/9306ab86-17ae-4602-aeaf-c56e14f4e0be>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/f2746dcc-055b-4a1a-8ec4-c2f284ddfb1a>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/593db4b0-54ac-4d6e-92d0-89a5d0da57ab>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@replay-io
Copy link

replay-io bot commented Apr 25, 2023

16 replays were recorded for 688f1a0.

image 1 Failed
    RBAC: Should not be able to delete contact as non-admin user
          ```
          page.goto: Navigation failed because page crashed!
          =========================== logs ===========================
          navigating to "localhost:9000/login", waiting until "load"
          ============================================================
          ```
        </ol>
      </details>
      
image 15 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/7163a711-13b2-425f-98d4-37a2ae8c3b2b>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/86a2e9b3-8f8b-448f-8cdb-d71200f2555a>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/84f0a3ec-c4ce-410a-b65c-7d5b2d579b62>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/ed7d45c4-6472-4e85-b4ef-62835cabf412>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/f5e16e58-5ade-40ed-90e6-5d6be63f033b>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/f9c1afa6-657f-4e25-8933-b5bf68c4d569>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/a0e4f574-e7a4-4f30-9dd3-5208640018ed>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/6874d20d-0f40-482a-94c1-b13821c9ac17>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/4b838ed2-a8c5-4e6b-8c87-30bcffee2254>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/65e19718-2dcf-42b8-b094-543985338ebf>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/b0c2703e-ada0-4269-b75e-d2a20c7df164>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/0c4733e4-f71b-4649-aad0-89a5c700b45a>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/cdad50b4-a941-4f09-b1f2-73bd1d93412a>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/8296471c-0e0d-4e0f-9ed9-26bdec4c24fe>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@jtoar jtoar added the fixture-ok Override the test project fixture check label Apr 25, 2023
@jtoar jtoar merged commit 09ab515 into main Apr 26, 2023
@jtoar jtoar deleted the renovate/listr2-6.x branch April 26, 2023 02:10
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Apr 26, 2023
@jtoar jtoar modified the milestones: next-release, v5.0.0 Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant