Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codemod): Fix replace-component-svgs codemod to deal with re-exported #9053

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Aug 22, 2023

Reported by startup club - the codemods were ignoring if the SVGs were rexported from a file like this:

import CurrencyYen from './currency-yen.svg'
import CursorClick from './cursor-click.svg'
import Database from './database.svg'
import Desktop from './desktop-computer.svg'
import DeviceMobile from './device-mobile.svg'

export { CurrencyYen, CursorClick, Database, Desktop, DeviceMobile }

@dac09
Copy link
Contributor Author

dac09 commented Aug 22, 2023

@Tobbe would you mind taking a look please?

@dac09 dac09 added this to the next-release-patch milestone Aug 22, 2023
@dac09 dac09 added the release:fix This PR is a fix label Aug 22, 2023
@Tobbe
Copy link
Member

Tobbe commented Aug 23, 2023

Just to show some sign of life from me here I thought I'd mention one more thing we should probably test, just to cover all our bases:

export { default as Mobile } from './device-mobile.svg'

I'll try it myself later unless you get to it first Danny

@dac09
Copy link
Contributor Author

dac09 commented Aug 23, 2023

I'll try it myself later unless you get to it first Danny

Done 👍

@dac09 dac09 enabled auto-merge (squash) August 23, 2023 06:43
@dac09 dac09 merged commit 220a753 into redwoodjs:main Aug 23, 2023
@jtoar jtoar modified the milestones: next-release-patch, v6.1.1 Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants