-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest): Include RWJS_DEBUG_ENV in jest web env #9065
Conversation
@Josh-Walker-GM any chance you could review this one and help get it in for patch? |
I can't reproduce the issue and so I don't yet understand what effect the changes here would have. The change to the jest preset looks good but I don't understand the change to the DevFatalErrorPage. Is that just to clean up invalid usage of This isn't my area of strength so I would be more than happy to defer to @dac09 if you think this is the fix. |
Same for me, but I think the issue would happen if you made your Layout or Page error out, so that it bubbles up to the nearest error boundary (which in the User's case was the FatalErrorBoundary).
Yes, the jest change should fix the error. In v6, we actually shipped a slightly different version of the code in DevFatalErrorPage. The |
deferring to you both on this and merging |
Fixes the issue described here: https://community.redwoodjs.com/t/redwood-v6-0-0-upgrade-guide/5044/70 Note that I'm unable to reproduce the actual failure, but it looks like a legitimate error to me (and I understand why).
Fixes the issue described here: https://community.redwoodjs.com/t/redwood-v6-0-0-upgrade-guide/5044/70 Note that I'm unable to reproduce the actual failure, but it looks like a legitimate error to me (and I understand why).
Fixes the issue described here: https://community.redwoodjs.com/t/redwood-v6-0-0-upgrade-guide/5044/70
Note that I'm unable to reproduce the actual failure, but it looks like a legitimate error to me (and I understand why).