fix: Refactor logic to enable/allow disable/not allow GraphiQL and Introspection Configuration in Dev vs Prod #9104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthyresson
added
bug/confirmed
dthyresson
commented
Aug 31, 2023
Josh-Walker-GM
approved these changes
Aug 31, 2023
jtoar
pushed a commit
that referenced
this pull request
Sep 2, 2023
…trospection Configuration in Dev vs Prod (#9104) There was a regression in the logic enabling/allowing GraphiQL and GraphQL introspection was being checked when creating GraphQL Yoga. This PR reworks the logic, extracts it, and adds tests to prevent the logic regression from happening in the future. --------- Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
jtoar
pushed a commit
that referenced
this pull request
Sep 2, 2023
…trospection Configuration in Dev vs Prod (#9104) There was a regression in the logic enabling/allowing GraphiQL and GraphQL introspection was being checked when creating GraphQL Yoga. This PR reworks the logic, extracts it, and adds tests to prevent the logic regression from happening in the future. --------- Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression in the logic enabling/allowing GraphiQL and GraphQL introspection was being checked when creating GraphQL Yoga.
This PR reworks the logic, extracts it, and adds tests to prevent the logic regression from happening in the future.