fix(types): wrong type path on server.config.js #9116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path for the Fastify configuration is not available at the current location when generating a new project.
Tobbe
approved these changes
Sep 1, 2023
|
Will do!
…On Fri, Sep 1, 2023, 10:46 Tobbe Lundberg ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Can you please make the same change in the JS template?
—
Reply to this email directly, view it on GitHub
<#9116 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABECTCRVRWY5GJUPVC2CYTXYGVGZANCNFSM6AAAAAA4HJ2N2U>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
FIY: i did the change via GitHub's web interface. Let me know if there's something else needed done on a local side and I'll clone it and go through the proper process. But since it was a type in a comment, I took that leap of faith :-D |
|
@rapzo Technically we should have updated the test project fixture too. But, as you said, it's just a type in a comment, so wasn't worth the extra cycle 😄 |
jtoar
pushed a commit
that referenced
this pull request
Sep 2, 2023
The path for the Fastify configuration is not available at the current location when generating a new project.
jtoar
pushed a commit
that referenced
this pull request
Sep 2, 2023
The path for the Fastify configuration is not available at the current location when generating a new project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path for the Fastify configuration is not available at the current location when generating a new project.