fix(cli): Prevent stale command cache defaults #9169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Sep 13, 2023
1 task
jtoar
pushed a commit
that referenced
this pull request
Sep 15, 2023
**Problem** #9150 highlights that there was a mistake in the cache loading logic. **Changes** 1. We merge the current cache state with the defaults - this will ensure that the defaults which are hard coded cannot be missing when the user updates versions. **Notes** I'm updating some of this plugin loading logic so expect a little churn in this code.
jtoar
pushed a commit
that referenced
this pull request
Sep 15, 2023
**Problem** #9150 highlights that there was a mistake in the cache loading logic. **Changes** 1. We merge the current cache state with the defaults - this will ensure that the defaults which are hard coded cannot be missing when the user updates versions. **Notes** I'm updating some of this plugin loading logic so expect a little churn in this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#9150 highlights that there was a mistake in the cache loading logic.
Changes
Notes
I'm updating some of this plugin loading logic so expect a little churn in this code.