Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: await Promise when seeding #9245

Merged
merged 6 commits into from
Oct 3, 2023
Merged

fix: await Promise when seeding #9245

merged 6 commits into from
Oct 3, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Sep 30, 2023

Currently this Promise is unhandled, meaning if it errors it won't get caught by the try/catch

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label Oct 1, 2023
@Josh-Walker-GM Josh-Walker-GM added this to the next-release-patch milestone Oct 1, 2023
Josh-Walker-GM
Josh-Walker-GM approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Don't worry about the type-check failure in the smoke test CI. It's failing across various PRs at the moment and we're working to fix it.

@Josh-Walker-GM Josh-Walker-GM merged commit e759b34 into redwoodjs:main Oct 3, 2023
30 checks passed
jtoar pushed a commit that referenced this pull request Oct 5, 2023
@G-Rath @jtoar
fix: await Promise when seeding (#9245)
582f3fb 
Currently this Promise is unhandled, meaning if it errors it won't get
caught by the `try/catch`
@jtoar jtoar modified the milestones: next-release-patch, v6.3.2 Oct 5, 2023
jtoar pushed a commit that referenced this pull request Oct 5, 2023
@G-Rath @jtoar
fix: await Promise when seeding (#9245)
0a085ec 
Currently this Promise is unhandled, meaning if it errors it won't get
caught by the `try/catch`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Walker-GM Josh-Walker-GM Josh-Walker-GM approved these changes

Assignees
No one assigned
Labels
release:fix This PR is a fix
Projects
None yet
Milestone
v6.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@G-Rath @Josh-Walker-GM @jtoar