fix(server-file): prefix MODULE_NOT_FOUND with ERR_
#9372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
added a commit
that referenced
this pull request
Nov 2, 2023
If you try to `await import` a module and it can't be found, it turns out Node throws a different error than if you try to `require` a module and it can't be found: - `require(mod)` -> `MODULE_NOT_FOUND` - `await import(mod)` -> `ERR_MODULE_NOT_FOUND` We used to tranpsile `await import`s to `require`. When we stopped doing that, we forgot to change the error codes we were checking.
jtoar
added a commit
that referenced
this pull request
Nov 3, 2023
If you try to `await import` a module and it can't be found, it turns out Node throws a different error than if you try to `require` a module and it can't be found: - `require(mod)` -> `MODULE_NOT_FOUND` - `await import(mod)` -> `ERR_MODULE_NOT_FOUND` We used to tranpsile `await import`s to `require`. When we stopped doing that, we forgot to change the error codes we were checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to
await importa module and it can't be found, it turns out Node throws a different error than if you try torequirea module and it can't be found:require(mod)->MODULE_NOT_FOUNDawait import(mod)->ERR_MODULE_NOT_FOUNDWe used to tranpsile
await imports torequire. When we stopped doing that, we forgot to change the error codes we were checking.