-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preview stats when building storybook for Chromatic "TurboSnap" #9462
preview stats when building storybook for Chromatic "TurboSnap" #9462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, it looks good! The only concern I had was that this wouldn't be opt-in and the new file generated appears to be quite large. On balance, I'd be happy to get this in as it is and get your setup working more smoothly.
You'll notice just a small linting warning on the files changed. We have a yarn lint --fix
command you can run from within the framework which should fix these for you. That's the only change I'm looking for here.
I can also just do that for you and then get this in if you'd prefer, that's not a problem either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah off the top of my head I'm not sure where all those other file changes have come from. No need for them in this PR.
Thanks again!
## Why is this PR created? The default `yarn rw storybook --build` doesn't generate preview-stats.json which is required for TurboSnap feature of Chromatic. ![image](https://github.com/redwoodjs/redwood/assets/43738254/bcab7455-0917-4fb2-95d3-afee174c8a6a) https://www.chromatic.com/docs/turbosnap/ ## How it's tested I made same change in my local environment and build my real project and confirmed successful build and generation of the preview-stats.json. ![image](https://github.com/redwoodjs/redwood/assets/43738254/15b1dd24-c0b9-497b-9775-d41984b1bc73)
Why is this PR created?
The default
yarn rw storybook --build
doesn't generate preview-stats.json which is required for TurboSnap feature of Chromatic.https://www.chromatic.com/docs/turbosnap/
How it's tested
I made same change in my local environment and build my real project and confirmed successful build and generation of the preview-stats.json.