Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sentry no longer supports tracing as a seperate package #9542

Merged
merged 7 commits into from
Dec 13, 2023

Conversation

ageddesi
Copy link
Contributor

I recently installed the sentry experimental setup and noticed that it is using deprecated implementations. I have updated these implementations to now use what they are expecting from the latest update.

Let me know if you think I have missed anything.

@ahaywood
Copy link
Contributor

Awesome! Thanks for submitting! We'll take a look.

@Tobbe Tobbe added the release:fix This PR is a fix label Nov 18, 2023
@Tobbe Tobbe added this to the next-release-patch milestone Nov 18, 2023
@ahaywood ahaywood assigned ahaywood and Josh-Walker-GM and unassigned ahaywood Nov 28, 2023
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, follows the sentry migration guide and I tested it locally where it worked well.

I am sorry it took me this long to get to reviewing this. Thanks for the PR it's hugely appreciated!

@Josh-Walker-GM Josh-Walker-GM enabled auto-merge (squash) December 13, 2023 01:00
@Josh-Walker-GM Josh-Walker-GM merged commit 4e34b17 into redwoodjs:main Dec 13, 2023
32 checks passed
Tobbe added a commit that referenced this pull request Dec 21, 2023
I recently installed the sentry experimental setup and noticed that it
is using deprecated implementations. I have updated these
implementations to now use what they are expecting from the latest
update.

Let me know if you think I have missed anything.

---------

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants