fix "Core Team" link #9621
Merged
fix "Core Team" link #9621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The https://github.com/redwoodjs/redwood README.md file changed, and now there is no `Core Team` header or `#core-team` anchor. The `#contributors` anchor seems like the best one to point to. Related: redwoodjs/redwoodjs.com#137.
|
Thanks @sqs! I'll review this a little later today |
Josh-Walker-GM
requested changes
Dec 5, 2023
There was a problem hiding this comment.
I think it might be better to link instead to the core-team-leadership like: https://github.com/redwoodjs/redwood#core-team-leadership. I think it would be nice to update the redwoodjs.com repository PR for to this leadership link too.
Let me know if you don't think so.
Tobbe
added a commit
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://github.com/redwoodjs/redwood README.md file changed, and now there is no
Core Teamheader or#core-teamanchor. The#contributorsanchor seems like the best one to point to.Related: redwoodjs/redwoodjs.com#137.