Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add custom inspect to work around a Prisma issue that causes console to hang #9623

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

ymc9
Copy link
Contributor

@ymc9 ymc9 commented Dec 4, 2023

The related Prisma issue: prisma/prisma#18292

It basically causes all kinds of Node REPLs that use PrismaClient to hang when users type the variable name that holds the client. Adding a workaround as suggested in the Prisma thread.

Fixes #8817

@Tobbe
Copy link
Member

Tobbe commented Dec 4, 2023

Thanks for bringing this workaround to our attention @ymc9. Really appreciate the PR.

I'll make sure someone does a proper review of this PR

@Tobbe Tobbe added the release:fix This PR is a fix label Dec 4, 2023
@Tobbe Tobbe added this to the next-release milestone Dec 4, 2023
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround linked to in the issue and comment is a from a member of the Prisma team, and it works great for me locally.

@jtoar jtoar merged commit db2f31f into redwoodjs:main Dec 5, 2023
28 of 32 checks passed
jtoar pushed a commit that referenced this pull request Dec 5, 2023
…sole to hang (#9623)

The related Prisma issue: prisma/prisma#18292

It basically causes all kinds of Node REPLs that use PrismaClient to
hang when users type the variable name that holds the client. Adding a
workaround as suggested in the Prisma thread.

Fixes #8817
@jtoar jtoar modified the milestones: next-release, v6.5.0 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: yarn rw console hangs for 10 seconds when typing 'db'
3 participants