chore(crwa): Convert Create Redwood App to ESM #9659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtuoushub
force-pushed
the
virtuoushub/esm/crwa/covert-to-esm
branch
from
fe4382b
to
2732f85
Compare
|
@virtuoushub We're running into NX cache issues from time to time on some PRs. That's what you saw here with all the tests failing. I cleared that up and re-ran the tests. Seems to be only one thing that's failing due to ESM now
|
awesome! thanks for your help with ea1d5a5 |
dthyresson
changed the title
|
This looks good, but please hold off merging until we've got a better plan in place for ESM support. |
|
Superseded by #9786 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also:
possibleTypesUpdate test project fixture with Trusted Documents changes #9560