Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: auth - Clerk - Corrects Home Page generation instructions #9662

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

dthyresson
Copy link
Contributor

See issue #9658

In the issue above, @swrichards found that if one places a Page.tsx in just the pages directory (ie, not /pages/PageName/PageName.tsx` and routes to it, one gets the following error building web / starting dev:

image

The found this while following the Clerk auth documentation -- and that said to make the HomePage in just the pages directory:

image

While this perhaps worked in the past, it doesn't seem to with the new site builds.

This PR updates the documentation to:

  • say to use the page generator
  • corrects filepath
  • removes outdated screenshot of old Clerk widget

The issue of the error will be assigned and resolved in a future PR.

@jtoar
Copy link
Contributor

jtoar commented Dec 13, 2023

Thanks @dthyresson it was probably just a typo

@jtoar jtoar merged commit 789de39 into main Dec 13, 2023
37 of 40 checks passed
@jtoar jtoar deleted the dt-clerk-auth-doc-page-issue branch December 13, 2023 17:04
Tobbe pushed a commit that referenced this pull request Dec 21, 2023
See issue #9658

In the issue above, @swrichards found that if one places a Page.tsx in
just the `pages` directory (ie, not /pages/PageName/PageName.tsx` and
routes to it, one gets the following error building web / starting dev:


![image](https://github.com/redwoodjs/redwood/assets/1051633/2246778f-424e-44f7-9e91-7c4ed10b2b89)

The found this while following the Clerk auth documentation -- and that
said to make the HomePage in just the `pages` directory:


![image](https://github.com/redwoodjs/redwood/assets/1051633/83bca047-0f31-4340-8ad3-bcf03000143f)

While this perhaps worked in the past, it doesn't seem to with the new
site builds.

This PR updates the documentation to:

* say to use the page generator
* corrects filepath
* removes outdated screenshot of old Clerk widget

The issue of the error will be assigned and resolved in a future PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs topic/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants