Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .vscode/settings.json files for ESLint setting #9723

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

lunchbreakdev
Copy link
Contributor

The source.fixAll.eslint setting changed from true to "explicit". It will actually correct this automatically on install

@Tobbe
Copy link
Member

Tobbe commented Dec 17, 2023

Thanks @morganmspencer. Great to see you in our PRs again! 😃

I had to do some research to understand what's going on. Here are some helpful links for future reference:
https://github.com/microsoft/vscode-eslint#version-204
https://stackoverflow.com/questions/77637621/vscode-workspace-settings-change-on-its-own

@Tobbe Tobbe added the release:fix This PR is a fix label Dec 17, 2023
@Tobbe Tobbe added this to the next-release-patch milestone Dec 17, 2023
@Tobbe Tobbe enabled auto-merge (squash) December 17, 2023 21:54
@Tobbe Tobbe merged commit 8d1e671 into redwoodjs:main Dec 17, 2023
32 checks passed
@lunchbreakdev lunchbreakdev deleted the patch-1 branch December 18, 2023 00:18
@lunchbreakdev
Copy link
Contributor Author

@Tobbe happy to be back from my hiatus! Thanks for adding those links, I was going to add those in but you beat me to it!

Tobbe added a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants