Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitpod): enable corepack to get proper node version #9732

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

colbywhite
Copy link
Contributor

this adds corepack enable in the gitpod init in order to properly set the node version.

Recreate the bug

visit https://gitpod.io/#https://github.com/redwoodjs/redwood

Test

visit gitpod via my branch: https://gitpod.io/#https://github.com/colbywhite/redwood/tree/fix.node.version

Fixes #9731

@jtoar jtoar added the release:fix This PR is a fix label Dec 20, 2023
@jtoar jtoar added this to the next-release-patch milestone Dec 20, 2023
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colbywhite!

@jtoar jtoar merged commit 347b4d9 into redwoodjs:main Dec 20, 2023
30 of 32 checks passed
@colbywhite colbywhite deleted the fix.node.version branch December 20, 2023 01:05
Tobbe pushed a commit that referenced this pull request Dec 21, 2023
this adds `corepack enable` in the gitpod init in order to properly set
the node version.

# Recreate the bug
visit https://gitpod.io/#https://github.com/redwoodjs/redwood

# Test
visit gitpod via my branch:
https://gitpod.io/#https://github.com/colbywhite/redwood/tree/fix.node.version

Fixes #9731

Co-authored-by: Colby M. White <colbywhite@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The gitpod env fails due to wrong node version
3 participants