Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apollo): Introduce TS type helper to reduce repetition #9943

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jan 31, 2024

By using RedwoodApolloLinks to build RedwoodApolloLinkName we make sure they're never out of sync

@Tobbe Tobbe changed the title chore(apollo): Introduce type helper to reduce repetition chore(apollo): Introduce TS type helper to reduce repetition Jan 31, 2024
@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Jan 31, 2024
@Tobbe Tobbe added this to the v7.0.0 milestone Jan 31, 2024
@Tobbe Tobbe merged commit 199fce1 into redwoodjs:main Jan 31, 2024
38 of 42 checks passed
@Tobbe Tobbe deleted the tobbe-apollo-types-link-type-helper branch January 31, 2024 07:16
@jtoar
Copy link
Contributor

jtoar commented Feb 1, 2024

@Tobbe I don't think this one needs to be in v7; swapping the milestone. Let me know if you think otherwise. Maybe you meant to refactor the index as well? https://github.com/Tobbe/redwood/blob/a7b1573148970062549c4c4ab9b53c9fa1a4f270/packages/web/src/apollo/index.tsx#L59-L63

@jtoar jtoar modified the milestones: v7.0.0, SSR Feb 1, 2024
@Josh-Walker-GM Josh-Walker-GM modified the milestones: SSR, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants