fix(server): make the default value of number field clearable

reearth · Oct 29, 2024 · 70085ad · 70085ad
1 parent 859fc79
commit 70085ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/server/pkg/value/number.go b/server/pkg/value/number.go
@@ -15,6 +15,9 @@ type propertyNumber struct{}
 type Number = float64
 
 func (p *propertyNumber) ToValue(i any) (any, bool) {
+	if i == "" {
+		return nil, true
+	}
 	switch v := i.(type) {
 	case float64:
 		return Number(v), true

diff --git a/server/pkg/value/number_test.go b/server/pkg/value/number_test.go
@@ -89,6 +89,12 @@ func Test_propertyNumber_ToValue(t *testing.T) {
 			want1: float64(now.Unix()),
 			want2: true,
 		},
+		{
+			name:  "empty string",
+			args:  []any{""},
+			want1: nil,
+			want2: true,
+		},
 		{
 			name:  "nil",
 			args:  []any{"foo", (*float64)(nil), (*string)(nil), (*int)(nil), (*json.Number)(nil), nil},