Fix b2cli 604 #90
Open
Fix b2cli 604 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzukowski-reef
commented
Jun 18, 2020
| """ | ||
| def __init__(self, content_sha1=None): | ||
| self.content_sha1 = content_sha1 # NOTE: b2sdk.transfer.upload_manager *writes* to this field |
There was a problem hiding this comment.
it is better to create a setter...
|
|
||
| @abstractmethod | ||
| def get_content_sha1(self): | ||
| """ | ||
| Return a 40-character string containing the hex SHA1 checksum of the data in the file. | ||
| Return a 40-character string containing the hex sha1 checksum of the data in the file. | ||
| The implementation of this method may cache the checksum value to avoid recalculating it. |
There was a problem hiding this comment.
I don't like this design - get_content_sha1 may or may not set the content_sha1 field... :/
| @@ -63,6 +67,8 @@ def read(self, size=None): | |||
| # Check for end of stream | |||
| if size is None or len(data) < size: | |||
| self.hash = self.digest.hexdigest() | |||
| if self.upload_source is not None: | |||
| self.upload_source.content_sha1 = self.hash | |||
mzukowski-reef
commented
Jun 18, 2020
| file_id, | ||
| part_number, | ||
| part_upload_source.get_content_length(), | ||
| HEX_DIGITS_AT_END, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.